Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document units of 34 real variables in vertFPmix #601

Merged

Conversation

Hallberg-NOAA
Copy link
Member

Added standard-format unit descriptions for 34 real variables in comments in the subroutine vertPFmix(). Another 6 comments were added noting dimensionally inconsistent expressions in vertFPmix(). Only comments are changed and all answers are bitwise identical.

  Added standard-format unit descriptions for 34 real variables in comments in
the subroutine vertPFmix.  Another 6 comments were added noting dimensionally
inconsistent expressions in vertFPmix.  Only comments are changed and all
answers are bitwise identical.
@Hallberg-NOAA Hallberg-NOAA added the documentation Improvements or additions to documentation label Apr 17, 2024
Copy link
Member

@gustavo-marques gustavo-marques left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for documenting these variables and adding comments about dimensional inconsistency. I will work with Bill Large to address these comments in a later PR.

@marshallward
Copy link
Member

Gaea regression: https://gitlab.gfdl.noaa.gov/ogrp/MOM6/-/pipelines ✔️

@marshallward marshallward merged commit 01b2ea9 into NOAA-GFDL:dev/gfdl Apr 23, 2024
10 checks passed
@Hallberg-NOAA Hallberg-NOAA deleted the vertFPmix_units_in_comments branch May 10, 2024 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants