+Add ALE options mimicking Hycom #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a number of options to MOM_ALE to mimic options that are found in Hycom. By default, all answers are bitwise identical, but there are several new runtime parameters. The code changes include: . Added the ability to use a different remapping scheme for velocities than for tracers, using the new runtime parameter VELOCITY_REMAPPING_SCHEME . Added the new runtime option PARTIAL_CELL_VELOCITY_REMAP to use partial cell thicknesses for remapping at velocity points, which triggers a call to the new internal routine apply_partial_cell_mask. . Added the new internal routine mask_near_bottom_vel to allow MOM6 to mimic Hycom in zeroing out the velocities in thin layers in a bottom boundary layer with a thickness given by the new runtime parameter REMAP_VEL_MASK_BBL_THICK, while the definition of thin is specified by REMAP_VEL_MASK_H_THIN. Setting these to be negative (as is the default) avoids this. . Modified the interface to remap_all_state_vars to take just the ALE_CS, which then provides the remapping control structure that is appropriate for the tracers or velocities, rather than also passing this in as an argument. . Eliminated some unnecessary internal variables, and added others to be more explicit avoid array syntax copies in arguments.
Codecov Report
@@ Coverage Diff @@
## dev/gfdl #77 +/- ##
=========================================
Coverage 29.04% 29.04%
=========================================
Files 244 244
Lines 71849 71893 +44
=========================================
+ Hits 20869 20884 +15
- Misses 50980 51009 +29
Continue to review full report at Codecov.
|
marshallward
approved these changes
Mar 5, 2022
|
Gaea regression: https://gitlab.gfdl.noaa.gov/ogrp/MOM6/-/pipelines/14879 ✔️ 🟡 This requires a parameter update. |
This was referenced May 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a number of options to MOM_ALE to mimic options that are found in
Hycom. By default, all answers are bitwise identical, but there are several
new runtime parameters. The code changes include:
Added the ability to use a different remapping scheme for velocities than
for tracers, using the new runtime parameter VELOCITY_REMAPPING_SCHEME
Added the new runtime option PARTIAL_CELL_VELOCITY_REMAP to use partial cell
thicknesses for remapping at velocity points, which triggers a call to the
new internal routine apply_partial_cell_mask.
Added the new internal routine mask_near_bottom_vel to allow MOM6 to mimic
Hycom in zeroing out the velocities in thin layers in a bottom boundary
layer with a thickness given by the new runtime parameter
REMAP_VEL_MASK_BBL_THICK, while the definition of thin is specified by
REMAP_VEL_MASK_H_THIN. Setting these to be negative (as is the default)
avoids this.
Modified the interface to remap_all_state_vars to take just the ALE_CS, which
then provides the remapping control structure that is appropriate for the
tracers or velocities, rather than also passing this in as an argument.
Eliminated some unnecessary internal variables, and added others to be
more explicit avoid array syntax copies in arguments.