Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reworked algebra corner spread, rotation parenthesis #90

Merged
merged 3 commits into from
Mar 23, 2022

Conversation

raphaeldussin
Copy link

this PR replaces now defunct PR #55

@codecov
Copy link

codecov bot commented Mar 15, 2022

Codecov Report

Merging #90 (1b3547f) into dev/gfdl (ce22d7a) will increase coverage by 0.04%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##           dev/gfdl      #90      +/-   ##
============================================
+ Coverage     28.95%   28.99%   +0.04%     
============================================
  Files           245      245              
  Lines         72240    72177      -63     
============================================
+ Hits          20914    20925      +11     
+ Misses        51326    51252      -74     
Impacted Files Coverage Δ
...c/parameterizations/lateral/MOM_internal_tides.F90 0.00% <0.00%> (ø)
src/core/MOM.F90 58.44% <0.00%> (+0.07%) ⬆️
src/core/MOM_barotropic.F90 37.70% <0.00%> (+0.41%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce22d7a...1b3547f. Read the comment docs.

Copy link
Member

@Hallberg-NOAA Hallberg-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with all of these changes, except for one minor syntax regression to an archaic (but still legal) form that can get reverted later.

@marshallward
Copy link
Member

Gaea regression: https://gitlab.gfdl.noaa.gov/ogrp/MOM6/-/pipelines/15056 ✔️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants