Error handler support #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev/gfdl #93 +/- ##
============================================
- Coverage 29.02% 28.99% -0.03%
============================================
Files 245 246 +1
Lines 72223 72296 +73
============================================
+ Hits 20962 20963 +1
- Misses 51261 51333 +72
Continue to review full report at Codecov.
|
marshallward
force-pushed
the
errhandle
branch
3 times, most recently
from
82eee31
to
778a186
Compare
This patch introduces some limited support for error handling in a POSIX environment. A partial interface to the POSIX system calls is included as part of the implementation of this feature. An internal global logical flag, `ignore_fatal` is added to the `MOM_error_handler` module which controls the behavior of `FATAL` errors. If true, then `FATAL` errors trigger a signal (here `SIGUSR1`) which call a handler which restores the program to the earlier state. This change allows us to test `FATAL` errors at runtime without stopping program execution, so that we can cycle through multiple errors. This feature is toggled with two new functions, `disable_fatal_errors()` and `enable_fatal_errors()`. This is implemented in part using POSIX system calls from the C standard library (libc), using the C interoperability layer. Details which are unspecified by the POSIX standard, such as the definitions of signals or the datatype size, are defined in a header (`posix.h`) which can be optionally configured at compile-time. The header defaults to use typical Linux POSIX values, and may be configured by autoconf for more exotic platforms in a later patch. The previous state is set and restored by the `setjmp`/`longjmp` (or `sigsetjmp`/`siglongjmp`) functions. Although these functions behave as expected on all tested platforms, a code which uses these functions is not standards-conforming. If issues arise in the future, error handling may not be available on those platforms, and compile-time configuration may be required to disable these features. No existing code is using these features, but are expected to be part of a future patch. Error handler API: * `disable_fatal_errors` * `enable_fatal_errors` New POSIX API: * `chmod` * `signal` * `kill` * `getpid` * `getppid` * `sleep` * `setjmp` * `sigsetjmp` * `longjmp` * `siglongjmp` New derived types: * `jmp_buf` * `sigjmp_buf` New interface (for signal handlers): * `handler_interface` New compile-time macros: * `JMP_BUF_SIZE` * `SIGJMP_BUF_SIZE` * `SIGSETJMP_NAME` * `POSIX_SIGUSR1`
|
While not necessarily the most appropriate place for it, it is the simplest place to park it for now. We can move it around when we have a more robust method of autogenerating the filepaths. |
adcroft
approved these changes
Mar 28, 2022
This was referenced May 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch introduces some limited support for error handling in a POSIX
environment. A partial interface to the POSIX system calls is included
as part of the implementation of this feature.
An internal global logical flag,
ignore_fatalis added to theMOM_error_handlermodule which controls the behavior ofFATALerrors. If true, then
FATALerrors trigger a signal (hereSIGUSR1)which call a handler which restores the program to the earlier state.
This change allows us to test
FATALerrors at runtime without stoppingprogram execution, so that we can cycle through multiple errors.
This feature is toggled with two new functions,
disable_fatal_errors()and
enable_fatal_errors().This is implemented in part using POSIX system calls from the C standard
library (libc), using the C interoperability layer. Details which are
unspecified by the POSIX standard, such as the definitions of signals or
the datatype size, are defined in a header (
posix.h) which can beoptionally configured at compile-time.
The header defaults to use typical Linux POSIX values, and may be
configured by autoconf for more exotic platforms in a later patch.
The previous state is set and restored by the
setjmp/longjmp(orsigsetjmp/siglongjmp) functions. Although these functions behave asexpected on all tested platforms, a code which uses these functions is
not standards-conforming. If issues arise in the future, error handling
may not be available on those platforms, and compile-time configuration
may be required to disable these features.
No existing code is using these features, but are expected to be part of
a future patch.
Error handler API:
disable_fatal_errorsenable_fatal_errorsNew POSIX API:
chmodsignalkillgetpidgetppidsleepsetjmpsigsetjmplongjmpsiglongjmpNew derived types:
jmp_bufsigjmp_bufNew interface (for signal handlers):
handler_interfaceNew compile-time macros:
JMP_BUF_SIZESIGJMP_BUF_SIZESIGSETJMP_NAMEPOSIX_SIGUSR1