-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
+Standardize diagnostic rescaling and get_param calls #97
+Standardize diagnostic rescaling and get_param calls #97
Commits on Mar 26, 2022
-
+Add optional conversion argument to register_diag_scalar
Add the optional conversion argument to register_diag_scalar, which works analogously to the argument that is already available in register_diag_field. All answers are bitwise identical, but there is a new optional argument in a public type.
Configuration menu - View commit details
-
Copy full SHA for 85cb708 - Browse repository at this point
Copy the full SHA 85cb708View commit details -
Convert global_area_mean diagnostics when writing
Use conversion argument during registration and tmp_scale argument in the calls to global_area_mean for averaged fields in the MOM_forcing_type and MOM_diagnostics modules. Also added or corrected some descriptive comments and fixed an extra unit conversion factor in one recently added calculation of ustar that was likely not used. All answers are bitwise identical.
Configuration menu - View commit details
-
Copy full SHA for 1b6aaf1 - Browse repository at this point
Copy the full SHA 1b6aaf1View commit details -
Simplify diagnostics using global_area_integral
Use the tmp_scale argument in calls to global_area_integral to simplify some global integrals, and added dimensional rescaling for the time_step element of the ice_shelf control structure. Also corrected some dimensional descriptions in comments. All answers are bitwise identical.
Configuration menu - View commit details
-
Copy full SHA for 5cef367 - Browse repository at this point
Copy the full SHA 5cef367View commit details -
Rescale new_depth in apply_topography_edits_from_file
Rescaled the new_depth variable in apply_topography_edits_from_file, and used source arguments to initialize 6 allocated variables. All answers are bitwise identical.
Configuration menu - View commit details
-
Copy full SHA for 81a318b - Browse repository at this point
Copy the full SHA 81a318bView commit details -
MOM_internal_tides diagnostic code simplification
Replaced a call to global_area_mean with a call to global_area_integral in a diagnostic calculation in the internal_tides module. Also added descriptions of the dimensions of a number of variables in this module, or eliminated the dimension description of several integers (for which units make no sense). Only an unused debugging diagnostic is changed, and all solutions are bitwise identical.
Configuration menu - View commit details
-
Copy full SHA for ffc97ab - Browse repository at this point
Copy the full SHA ffc97abView commit details -
+Avoid nonsensical units descriptions
Eliminated units arguments for logical, integer, or character string get_param calls where the units make no sense. In some other cases, calls were slightly revised to place the units and scale arguments on the same line for easier detection of inconsistent settings. All answers are bitwise identical, but the MOM_parameter_doc.all files for some test cases are corrected.
Configuration menu - View commit details
-
Copy full SHA for e0e88cf - Browse repository at this point
Copy the full SHA e0e88cfView commit details -
Minor get_param call reformatting
Revised get_param calls to put the units and scale arguments on the same line, to help detect inconsistent settings. All answers and output are bitwise identical.
Configuration menu - View commit details
-
Copy full SHA for ecf3ab0 - Browse repository at this point
Copy the full SHA ecf3ab0View commit details -
MOM_neutral_diffusion code cleanup
Eliminated a commented-out get_param call and use a source argument to initialize some arrays. All answers and output are bitwise identical.
Configuration menu - View commit details
-
Copy full SHA for fad341e - Browse repository at this point
Copy the full SHA fad341eView commit details -
+Corrected units in dumbbell get_param calls
Corrected the units in some get_param calls in the dumbbell test case. All answers are bitwise identical, but there will be minor changes in the MOM_parameter_doc files for the dumbbell test case.
Configuration menu - View commit details
-
Copy full SHA for 4c70d40 - Browse repository at this point
Copy the full SHA 4c70d40View commit details
Commits on Apr 2, 2022
-
Configuration menu - View commit details
-
Copy full SHA for a4bbcb4 - Browse repository at this point
Copy the full SHA a4bbcb4View commit details