Icepack bugfix sst #179
Merged
Icepack bugfix sst #179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
with regard to sea surface temperature. This should prevent potential model failures due to uninitialized array access from with Icepack. These changes do not impact cases with Icepack disabled.
Hallberg-NOAA
approved these changes
Aug 3, 2022
There was a problem hiding this comment.
I agree that these changes are correct, and moreover that they will address the issue at the source of mom-ocean/MOM6#1461, which can now be closed.
I have run these changes through the suite SIS2-based models in the MOM6-examples test suite, and all answers are bitwise identical. I could envision that there might be answer changes in cases using the Icepack-derived ridging scheme, but if so I am confident that the new answers are the right ones, and that they avoid the possibility of NaNs in uninitialized arrays bringing down the model, and hence that there are no defensible previous answers that could be preserved.
|
Gaea regression: https://gitlab.gfdl.noaa.gov/ogrp/SIS2/-/pipelines/16281 ✔️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes a problem with initialization of sea surface temperature information for the Icepack module and should avoid uninitalized array access within Icepack. This should not impact answers for existing simulations using Icepack ridging.