Submodule parsing support; hashing fix #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch adds support for identifying submodules and tagging the parent module as their dependency. Expressions as `submodule (some_mod) some_submod` will tag the object file of `some_mod` as a dependency of the source file of `some_submod`. --- This patch also modifies the module regexp to reject any of the following: - module procedure - module subroutine - module function The latter two are used when working with submodules. The first is typically used for generic interfaces. Previously the `procedure` exception was applied to the consistency check, but it may have inadvertently been adding a module named `procedure` to the hashes. This was probably not causing any errors, but was probably nonetheless not the desired behavior. This change prevents any of the subprogram keywords from being added to the hashes.
underwoo
approved these changes
Oct 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds support for identifying submodules and tagging the
parent module as their dependency.
Expressions as
submodule (some_mod) some_submodwill tag the objectfile of
some_modas a dependency of the source file ofsome_submod.This patch also modifies the module regexp to reject any of the
following:
The latter two are used when working with submodules. The first is
typically used for generic interfaces.
Previously the
procedureexception was applied to the consistencycheck, but it may have inadvertently been adding a module named
procedureto the hashes. This was probably not causing any errors,but was probably nonetheless not the desired behavior.
This change prevents any of the subprogram keywords from being added to
the hashes.