Adds an option to override the real precision to r4 #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bensonr
reviewed
Jul 1, 2024
@bensonr Should all templates be updated? |
|
@uramirez8707 - I think we should make this available in the same manner for all compiler templates contained within the mkmf system. The SHiELD model and build system also support the NVidia HPC Toolkit and GCC compilers. As the SHiELD build system is phased out in favor of the updated fre-cli, we need to ensure any templates used by this new system have the proper support. |
uramirez8707
commented
Sep 5, 2024
templates/ncrc5-intel-classic.mk
Outdated
Comment on lines
83
to
89
| ifdef USE_R4 | ||
| REAL_PRECISION := -r4 | ||
| CPPDEFS += -DOVERLOAD_R4 | ||
| else | ||
| REAL_PRECISION := -r8 | ||
| endif | ||
|
|
There was a problem hiding this comment.
@bensonr
should we be using -real-size 32 and real-size 64 instead?
There was a problem hiding this comment.
@uramirez8707 - Yes, I think we should be using the updated -real-size for both OneAPI and classic ifort.
bensonr
approved these changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This can be used in an xmls by doing
For the component that you want to use r4 for.
This option will allow us to compile different components at different precisions (i.e compile fv3 in r4 and everything else in r8)