CI: pin ubuntu runner to 20.04 to avoid sanitizer failures

.github/workflows/module_integration.yml

@@ -22,7 +22,7 @@ jobs:
     # The type of runner that the job will run on
     strategy:
       matrix:
-        os: [ubuntu-latest, macos-latest]
+        os: [ubuntu-20.04, macos-latest]
       fail-fast: false
     runs-on: ${{ matrix.os }}
 
@@ -55,7 +55,7 @@ jobs:
     # The type of runner that the job will run on
     strategy:
       matrix:
-        os: [ubuntu-latest] # [ubuntu-latest, macos-latest] #TODO: Fix #505
+        os: [ubuntu-20.04] # [ubuntu-latest, macos-latest] #TODO: Fix #505
       fail-fast: false
     runs-on: ${{ matrix.os }}
 

.github/workflows/test_and_validate.yml

@@ -24,7 +24,7 @@ jobs:
     # The type of runner that the job will run on
     strategy:
       matrix:
-        os: [ubuntu-latest, macos-latest]
+        os: [ubuntu-20.04, macos-latest]
       fail-fast: false
     runs-on: ${{ matrix.os }}
 
@@ -59,7 +59,7 @@ jobs:
     # The type of runner that the job will run on
     strategy:
       matrix:
-        os: [ubuntu-latest, macos-latest]
+        os: [ubuntu-20.04, macos-latest]
       fail-fast: false
     runs-on: ${{ matrix.os }}
 
@@ -87,7 +87,7 @@ jobs:
     # The type of runner that the job will run on
     strategy:
       matrix:
-        os: [ubuntu-latest]
+        os: [ubuntu-20.04]
       fail-fast: false
     runs-on: ${{ matrix.os }}
 
@@ -116,7 +116,7 @@ jobs:
     # The type of runner that the job will run on
     strategy:
       matrix:
-        os: [ubuntu-latest, macos-latest]
+        os: [ubuntu-20.04, macos-latest]
       fail-fast: false
     runs-on: ${{ matrix.os }}
 
@@ -151,7 +151,7 @@ jobs:
     # The type of runner that the job will run on
     strategy:
       matrix:
-        os: [ubuntu-latest, macos-latest]
+        os: [ubuntu-20.04, macos-latest]
       fail-fast: false
     runs-on: ${{ matrix.os }}
 
@@ -184,7 +184,7 @@ jobs:
     # The type of runner that the job will run on
     strategy:
       matrix:
-        os: [ubuntu-latest, macos-latest]
+        os: [ubuntu-20.04, macos-latest]
       fail-fast: false
     runs-on: ${{ matrix.os }}
 
@@ -217,7 +217,7 @@ jobs:
     # The type of runner that the job will run on
     strategy:
       matrix:
-        os: [ubuntu-latest, macos-latest]
+        os: [ubuntu-20.04, macos-latest]
       fail-fast: false
     runs-on: ${{ matrix.os }}
 
@@ -252,7 +252,7 @@ jobs:
     # The type of runner that the job will run on
     strategy:
       matrix:
-        os: [ubuntu-latest, macos-latest]
+        os: [ubuntu-20.04, macos-latest]
       fail-fast: false
     runs-on: ${{ matrix.os }}
 

include/NGenConfig.h.in

@@ -47,7 +47,7 @@ namespace exec_info
 
     void runtime_summary(std::ostream& stream) noexcept;
     void runtime_usage(const std::string& cmd, std::ostream& stream) noexcept;
-};
+}
 
 } // namespace ngen
 

include/realizations/catchment/Formulation_Constructors.hpp

@@ -29,7 +29,7 @@ namespace realization {
         return [](std::string id, std::shared_ptr<data_access::GenericDataProvider> forcing_provider, utils::StreamHandler output_stream) -> std::shared_ptr<Catchment_Formulation>{
             return std::make_shared<T>(id, forcing_provider, output_stream);
         };
-    };
+    }
 
     static std::map<std::string, constructor> formulations = {
         {"bmi_c++", create_formulation_constructor<Bmi_Cpp_Formulation>()},
@@ -83,7 +83,7 @@ namespace realization {
                     "\", provider: \"" + forcing_config.provider + "\"");
         }
         return formulation_constructor(identifier, fp, output_stream);
-    };
+    }
 
     static std::string get_formulation_key(const boost::property_tree::ptree &tree) {
         /*for (auto &node : tree) {

include/realizations/config/config.hpp

@@ -55,6 +55,6 @@ namespace realization{
     };
 
 
-  };//end namespace config
+  }//end namespace config
 }//end namespace realization
 #endif //NGEN_REALIZATION_CONFIG_H

include/realizations/config/forcing.hpp

@@ -53,6 +53,6 @@ namespace realization{
   };
 
 
-  };//end namespace config
+  }//end namespace config
 }//end namespace realization
 #endif //NGEN_REALIZATION_CONFIG_FORCING_H

include/realizations/config/formulation.hpp

@@ -130,6 +130,6 @@ namespace realization{
     }
   };
 
-  };//end namespace config
+  }//end namespace config
 }//end namespace realization
 #endif //NGEN_REALIZATION_CONFIG_FORMULATION_H

include/realizations/config/routing.hpp

@@ -16,6 +16,6 @@ namespace realization{
         }
     };
 
-  };//end namespace config
+  }//end namespace config
 }//end namespace realization
 #endif //NGEN_REALIZATION_CONFIG_ROUTING_H

include/realizations/config/time.hpp

@@ -74,6 +74,6 @@ namespace realization{
                     );
         }
     };
-  };//end namespace config
+  }//end namespace config
 }//end namespace realization
 #endif //NGEN_REALIZATION_CONFIG_TIME_H

src/geojson/FeatureCollection.cpp

@@ -64,7 +64,7 @@ Feature FeatureCollection::remove_feature_by_id(std::string ID) {
 
 int FeatureCollection::get_size() {
     return features.size();
-};
+}
 
 bool FeatureCollection::is_empty() {
     return features.size() == 0;

src/geojson/JSONProperty.cpp

@@ -18,7 +18,7 @@ long JSONProperty::as_natural_number() const {
     // Throw an exception since this can't be considered a natural number
     std::string message = key + " is a " + get_propertytype_name(get_type()) + " and cannot be converted into a natural number.";
     throw std::runtime_error(message);
-};
+}
 
 /**
  * Get the type of the property (Natural, Real, String, etc)
@@ -27,7 +27,7 @@ long JSONProperty::as_natural_number() const {
  */
 PropertyType JSONProperty::get_type() const {
     return type;
-};
+}
 
 
 double JSONProperty::as_real_number() const {
@@ -40,7 +40,7 @@ double JSONProperty::as_real_number() const {
 
     std::string message = key + " is a " + get_propertytype_name(get_type()) + " and cannot be converted into a real number.";
     throw std::runtime_error(message);
-};
+}
 
 bool JSONProperty::as_boolean() const {
     if (type == PropertyType::Boolean) {
@@ -49,7 +49,7 @@ bool JSONProperty::as_boolean() const {
 
     std::string message = key + " is a " + get_propertytype_name(get_type()) + " and cannot be converted into a boolean.";
     throw std::runtime_error(message);
-};
+}
 
 std::vector<JSONProperty> JSONProperty::as_list() const {
     std::vector<JSONProperty> copy;
@@ -131,7 +131,7 @@ std::string JSONProperty::as_string() const {
 
     std::string message = key + " is a " + get_propertytype_name(get_type()) + " and cannot be converted into a string.";
     throw std::runtime_error(message);
-};
+}
 
 JSONProperty JSONProperty::at(std::string key) const {
     if (type == PropertyType::Object) {

src/geopackage/ngen_sqlite.cpp

@@ -14,7 +14,7 @@ sqlite_error::sqlite_error(const std::string& origin_func, int code, const std::
     origin_func + " returned code " + std::to_string(code)
         + " (msg: " + sqlite3_errstr(code) + ")"
         + (extra.empty() ? "" : " " + extra)
-  ){};
+  ){}
 
 const auto sqlite_not_started_error = sqlite_error{
     "sqlite iteration is has not started, get() is not callable "
@@ -41,7 +41,7 @@ database::iterator::iterator(stmt_t&& stmt)
     }
 
     restart();
-};
+}
 
 auto database::iterator::ptr_() const noexcept -> sqlite3_stmt*
 {

src/routing/Routing_Py_Adapter.cpp

@@ -32,7 +32,7 @@ Routing_Py_Adapter::Routing_Py_Adapter(std::string t_route_config_file_with_path
 void Routing_Py_Adapter::route(int number_of_timesteps, int delta_time,
                           const std::vector<double> &flow_vector){
   throw "Routing_Py_Adapter::route overload with flow_vector unimplemented.";
-};
+}
 
 void Routing_Py_Adapter::route(int number_of_timesteps, int delta_time)
 {