Rename config to nrchkbConfig for isolation purpose
#565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GogoVega
requested review from
Shaquu,
caitken-com,
crxporter and
TheNON75
as code owners
|
I wonder if it’s possible to scope all those variables inside a function. |
|
Yes with IIFE but also need to modify the nodes to reflect this changes. |
Shaquu
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
nrchkbnode is not isolated which means that all variables in the top scope are global.In order to avoid a variable duplication that prevents the
homekit-servicenode from instantiating, I renamedconfigtonrchkbConfig. Because it's a common variable name.