Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

linking requirements.txt in .pyproject.toml #9

Merged
merged 2 commits into from
Aug 21, 2024
Merged

Conversation

jfbourgon
Copy link
Collaborator

closes #8

@@ -0,0 +1 @@
2.0.7
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are you using a different tool to create the VERSION file?

Copy link
Collaborator Author

@jfbourgon jfbourgon Aug 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added the new VERSON file in the lists of file managed by bumpver

@@ -4,7 +4,6 @@ build-backend = "setuptools.build_meta"

[project]
name = "geo-inference"
version = "2.0.7"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was updated automatically using bumpver,

Copy link
Collaborator Author

@jfbourgon jfbourgon Aug 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes it is still but it is now managed through a centralized VERSION file, however we could potentially argue on the plus-value of that centralized file since the version number is still present in other locations.
Here is an updated output of the bumpver command with the new conifg

bumpver update --minor --dry
INFO    - fetching tags from remote (to turn off use: -n / --no-fetch)
INFO    - Old Version: 2.0.7
INFO    - New Version: 2.1.0
--- VERSION
+++ VERSION
@@ -1 +1 @@
-2.0.7
+2.1.0
--- geo_inference/__init__.py
+++ geo_inference/__init__.py
@@ -1,5 +1,5 @@
 """Geo-inference: Extract features from high-resolution geospatial imagery using foundation models"""

 __author__ = "Victor Alhassan"
-__version__ = "2.0.7"
+__version__ = "2.1.0"

--- pyproject.toml
+++ pyproject.toml
@@ -37,7 +37,7 @@
 include = ["geo_inference*"]

 [tool.bumpver]
-current_version = "2.0.7"
+current_version = "2.1.0"
 version_pattern = "MAJOR.MINOR.PATCH"
 commit_message = "bump version {old_version} -> {new_version}"
 commit = true

@mpelchat04 mpelchat04 merged commit cd37d4a into NRCan:main Aug 21, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

update pip install dependencies
3 participants