Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add mapping for ewiz specific model #25

Merged
merged 2 commits into from
Jul 22, 2024
Merged

Add mapping for ewiz specific model #25

merged 2 commits into from
Jul 22, 2024

Conversation

spodgorny9
Copy link
Collaborator

No description provided.

grantbuster
grantbuster requested changes Jul 19, 2024
View reviewed changes
Copy link
Member

@grantbuster grantbuster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should make tokenizer_aliases into a class attribute and modify it in the ewiz deployment subclass

grantbuster
grantbuster requested changes Jul 22, 2024
View reviewed changes
Copy link
Member

@grantbuster grantbuster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Class attributes should be in ALL_CAPS as they are basically global variables. You should include the descriptive comment in the line below the class attribute as a """docstring"""

@spodgorny9 spodgorny9 merged commit 0d3e7e5 into main Jul 22, 2024
12 checks passed
@spodgorny9 spodgorny9 deleted the sp/ewiz_model_mapping branch July 22, 2024 15:32
github-actions bot pushed a commit that referenced this pull request Jul 22, 2024
@spodgorny9
Merge pull request #25 from NREL/sp/ewiz_model_mapping
2d1b7a2 
Add mapping for ewiz specific model
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grantbuster grantbuster grantbuster approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@spodgorny9 @grantbuster