Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

search termination criteria fix #181

Merged
merged 1 commit into from
Apr 4, 2024
Merged

search termination criteria fix #181

merged 1 commit into from
Apr 4, 2024

Conversation

robfitzgerald
Copy link
Collaborator

this PR addresses the incorrect logic in the edge rtree search, which previously could visit every edge in the graph for degenerative cases where no valid links exist within the tolerance distance.

Closes #180.

Copy link
Collaborator

@nreinicke nreinicke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good find!!

@robfitzgerald robfitzgerald merged commit 5ef2f58 into main Apr 4, 2024
5 checks passed
@robfitzgerald robfitzgerald deleted the rjf/endless-rtree branch April 4, 2024 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

edge rtree will explore entire graph in degenerate cases
2 participants