Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OSM/Geospatial dependencies as default #233

Merged
merged 4 commits into from
May 21, 2024
Merged

Add OSM/Geospatial dependencies as default #233

merged 4 commits into from
May 21, 2024

Conversation

nreinicke
Copy link
Collaborator

Previously we only had the OSM/Geospatial dependencies required in the conda install but now that we're adding default functionality that use these dependencies (osmnx, geopandas, etc.), I've included them as required dependencies in the pyproject.toml file.

@robfitzgerald
Copy link
Collaborator

Oh, seeing this one now. I'm not sure I agree with the idea of making these required. Perhaps they could be a feature install, and that feature is the default, but can be deactivated? Osmnx is a heavy weight dependency and it's not actually a requirement for all downstream compass applications (same goes for all of these geospatial libs)

@nreinicke
Copy link
Collaborator Author

Yeah that's a good point and I like the idea of making the geospatial libraries optional. Then for type checking we can do:

from typing import TYPE_CHECKING

if TYPE_CHECKING:
  import osmnx

@jhoshiko
Copy link
Collaborator

Discussed this with Nick in person and am approving this change.

@jhoshiko jhoshiko merged commit 129eef5 into main May 21, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants