Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parallelize + show progress for input plugins #57

Merged
merged 2 commits into from
Nov 30, 2023

Conversation

robfitzgerald
Copy link
Collaborator

@robfitzgerald robfitzgerald commented Nov 30, 2023

this PR parallelizes the input plugin operations using the same chunking approach as the search/output plugin parallelization. it also adds a progress bar (using mutex for shared access) to the processing:

input plugins:   7%|█████████▆                                                       |  155/2204 [00:17<03:56, 8.67it/s]

edit: realized i could also add a progress bar for the searches too.

input plugins: 100%|█████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████| 2204/2204 [04:24<00:00, 8.33it/s]
[2023-11-30T21:35:39Z INFO  routee_compass::app::compass::compass_app] creating 12 parallel batches across 16 threads to run queries with chunk size 520
search:   2%|██▇                                                                                                                                             |  118/6240 [00:27<23:40, 4.31it/s]

Closes #56.

Copy link
Collaborator

@nreinicke nreinicke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, love that we can have progress bars for both of those steps now. Thanks for adding in!

@robfitzgerald robfitzgerald merged commit 39f5f57 into main Nov 30, 2023
5 checks passed
@robfitzgerald robfitzgerald deleted the rjf/parallel-input-plugins branch November 30, 2023 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

parallelize input plugin operations
2 participants