Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
edit
this PR modified the signature of methods in
config_json_extension.rs
so that string arguments are references and they can beString
orstr
types. this makes it so cloning of key names is no longer required for using these methods and at the same time, allows'static str
arguments, which greatly reduces boilerplate for some applications.original post
Nick - started this work to relax what we can pass as arguments to the JSON getter extensions we have. this
.clone()
keys a lotjust letting you know about it, it's going to touch a lot of files, just making sure this doesn't mess with anything you are up to this morning.
Closes #79.