Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update library calls to std:: namespace per SAM issue 1224 #175

Merged
merged 1 commit into from
Jul 30, 2024
Merged

Update library calls to std:: namespace per SAM issue 1224 #175

merged 1 commit into from
Jul 30, 2024

Conversation

sjanzou
Copy link
Collaborator

@sjanzou sjanzou commented Jul 29, 2024 •
edited
Loading

goes with NREL/ssc#1192

@sjanzou sjanzou self-assigned this Jul 29, 2024
@sjanzou sjanzou mentioned this pull request Jul 29, 2024
Merged
@sjanzou sjanzou linked an issue Jul 29, 2024 that may be closed by this pull request
Check NREL external libraries for std prefix before abs() and isnan() NREL/SAM#1224
Closed
brtietz
brtietz approved these changes Jul 29, 2024
View reviewed changes
Copy link
Collaborator

@brtietz brtietz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!

@sjanzou sjanzou merged commit 3abf414 into patch Jul 30, 2024
8 checks passed
@sjanzou sjanzou deleted the SAM_1224 branch July 30, 2024 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brtietz brtietz brtietz approved these changes

@janinefreeman janinefreeman Awaiting requested review from janinefreeman

@tyneises tyneises Awaiting requested review from tyneises

Assignees

@sjanzou sjanzou

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Check NREL external libraries for std prefix before abs() and isnan()
2 participants
@sjanzou @brtietz