Skip to content
This repository has been archived by the owner on Jul 3, 2023. It is now read-only.

Remove hot module replacement #291

Merged
merged 2 commits into from
Aug 18, 2019
Merged

Remove hot module replacement #291

merged 2 commits into from
Aug 18, 2019

Conversation

BrendanAnnable
Copy link
Member

@BrendanAnnable BrendanAnnable commented Aug 18, 2019 •
edited
Loading

This PR removes hot module replacement and react hot loader because:

  • Mobx does not officially support either
  • We are unable to upgrade mobx-react without this change
  • Hooks are not supported
  • We now use storybook primarily for development, so this feature shouldn't really be used
  • This lets us put everything back into main.tsx! 🎉

TrentHouliston
TrentHouliston reviewed Aug 18, 2019
View reviewed changes
Copy link
Member

@TrentHouliston TrentHouliston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BrendanAnnable BrendanAnnable requested a deployment to nusight-pr-291 August 18, 2019 07:43 Abandoned
TrentHouliston
TrentHouliston previously approved these changes Aug 18, 2019
View reviewed changes
@BrendanAnnable BrendanAnnable requested a deployment to nusight-pr-291 August 18, 2019 07:45 Abandoned
TrentHouliston
TrentHouliston approved these changes Aug 18, 2019
View reviewed changes
Copy link
Member

@TrentHouliston TrentHouliston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still LGTM

@BrendanAnnable BrendanAnnable merged commit 55fd202 into master Aug 18, 2019
@BrendanAnnable BrendanAnnable deleted the annable/remove-hmr branch August 18, 2019 07:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@TrentHouliston TrentHouliston TrentHouliston approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BrendanAnnable @TrentHouliston