Removing hard-set versions from requirements.txt to be more compatible with RAPIDS #245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjnolet
changed the title
|
I agree these shouldn't be fixed to specific versions and should eventually be a range, but can we use a ">=" semantic instead as a start? Very much looking forward to seeing this get repaired and released! |
|
@edawson I made the requested change and verified that the environment still works after building. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm currently updating the
rapids-single-cell-examplesrepository to use RAPIDS 21.08 but the firm versions in the atacworks python package are causing numerous conflicts with the rest of the packages in the ecosystem. I propose we remove the hard-set versions since, as far as I can tell, nothing in this repository requires them. If we do that there are version issues over time, we should consider setting bounds with ranges instead of locking to an exact version.