Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove hugectr inference #1065

Closed
wants to merge 4 commits into from
Closed

Remove hugectr inference #1065

wants to merge 4 commits into from

Conversation

EmmaQiaoCh
Copy link
Contributor

@EmmaQiaoCh EmmaQiaoCh commented Sep 18, 2023 •
edited
Loading

Remove hugectr inference backend;
Add installation of hps_torch in merlin-torch.

@copy-pr-bot
Copy link

copy-pr-bot bot commented Sep 18, 2023

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@github-actions
Copy link

Documentation preview

https://nvidia-merlin.github.io/Merlin/review/pr-1065

@bashimao
Copy link
Contributor

Do we really want to remove that?

@EmmaQiaoCh
Copy link
Contributor Author

Do we really want to remove that?

Yes, I checked with Yingcan. Could you review it again^^

@EmmaQiaoCh EmmaQiaoCh added the enhancement New feature or request label Sep 19, 2023
@jperez999
Copy link
Collaborator

/ok to test

@EmmaQiaoCh
Copy link
Contributor Author

The copied PR is merged

@EmmaQiaoCh EmmaQiaoCh closed this Sep 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bashimao bashimao Awaiting requested review from bashimao

@minseokl minseokl Awaiting requested review from minseokl

Assignees
No one assigned
Labels
23.09 enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@EmmaQiaoCh @bashimao @jperez999