Add DLRM block #1162
Merged
Add DLRM block #1162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Documentation preview |
Co-authored-by: Radek Osmulski <[email protected]>
edknv
commented
Jul 1, 2023
Comment on lines
-33
to
+34
| with pytest.raises(ValueError): | ||
| outputs.add_route(Tags.CATEGORICAL) | ||
| outputs.add_route(Tags.CATEGORICAL) |
There was a problem hiding this comment.
This was changed to not raise an error because it is possible that there is no continuous features in the DLRM block. Alternatively, we could have a try-except in the DLRM block, but this felt more natural to me.
edknv
commented
Jul 1, 2023
Comment on lines
-136
to
138
| feature = [[1.0, 2.0], [3.0, 4.0]] | ||
| target = [[0.0], [1.0]] | ||
| feature = [2.0, 3.0] | ||
| target = [0.0, 1.0] | ||
| dataset = Dataset(pd.DataFrame({"feature": feature, "target": target})) |
There was a problem hiding this comment.
This test case was incorrect because feature = [[1.0, 2.0], [3.0, 4.0]] will produce a list column.
marcromeyn
approved these changes
Jul 1, 2023
Merged
29 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the DLRM block in the PyTorch backend.