Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve hpo test #1222

Merged
merged 2 commits into from
Oct 31, 2023
Merged

improve hpo test #1222

merged 2 commits into from
Oct 31, 2023

Conversation

radekosmulski
Copy link
Contributor

The test on the hpo use case has been failing in recent pr -- this attempts to fix the problem.

@copy-pr-bot
Copy link

copy-pr-bot bot commented Oct 23, 2023

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@radekosmulski radekosmulski added the bug Something isn't working label Oct 23, 2023
@github-actions
Copy link

Documentation preview

https://nvidia-merlin.github.io/models/review/pr-1222

@edknv
Copy link
Contributor

edknv commented Oct 31, 2023

/ok to test

@radekosmulski radekosmulski merged commit 7d99e53 into main Oct 31, 2023
38 of 42 checks passed
@rnyak rnyak deleted the fix_hpo_test branch October 31, 2023 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliverholworthy oliverholworthy oliverholworthy approved these changes

@rnyak rnyak Awaiting requested review from rnyak

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@radekosmulski @edknv @oliverholworthy