Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix dependencies in docs build #1236

Merged
merged 2 commits into from
Jan 8, 2024

Conversation

edknv
Copy link
Contributor

@edknv edknv commented Jan 7, 2024

docs-build in the CI is failing due to pip failing to resolve dependencies, e.g.,

Collecting nbformat~=5.0 (from myst-nb->-r requirements/docs.txt (line 4))
  Downloading nbformat-5.9.1-py3-none-any.whl.metadata (3.3 kB)
INFO: pip is still looking at multiple versions of pydata-sphinx-theme to determine which version is compatible with other requirements. This could take a while.
INFO: This is taking longer than usual. You might need to provide the dependency resolver with stricter constraints to reduce runtime. See https://pip.pypa.io/warnings/backtracking for guidance. If you want to abort this run, press Ctrl + C.
INFO: pip is still looking at multiple versions of sqlalchemy to determine which version is compatible with other requirements. This could take a while.
INFO: This is taking longer than usual. You might need to provide the dependency resolver with stricter constraints to reduce runtime. See https://pip.pypa.io/warnings/backtracking for guidance. If you want to abort this run, press Ctrl + C.

This PR fixes package versions in requirements/docs.txt to help the dependency resolver. It also replaces test.txt with dev.txt since the requirements in the latter are narrower and dev.txt doesn't install the unnecessary requirements that cause conflicts.

@edknv edknv added documentation Improvements or additions to documentation ci chore Maintenance for the repository labels Jan 7, 2024
Copy link

github-actions bot commented Jan 7, 2024

Documentation preview

https://nvidia-merlin.github.io/models/review/pr-1236

@edknv edknv marked this pull request as ready for review January 7, 2024 06:52
@edknv edknv mentioned this pull request Jan 7, 2024
@edknv edknv requested a review from EmmaQiaoCh January 7, 2024 06:59
@edknv edknv merged commit 2bec1a5 into NVIDIA-Merlin:main Jan 8, 2024
36 checks passed
@edknv edknv deleted the ci/docs-build-fix-deps branch January 8, 2024 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Maintenance for the repository ci documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants