Integrate RMM #2609
Integrate RMM #2609
Conversation
Signed-off-by: Michał Zientkiewicz <[email protected]>
|
!build |
|
CI MESSAGE: [1975053]: BUILD STARTED |
|
CI MESSAGE: [1975053]: BUILD FAILED |
Use RMM interfaces in dali::mm. Signed-off-by: Michał Zientkiewicz <[email protected]>
|
CI MESSAGE: [1976929]: BUILD STARTED |
|
CI MESSAGE: [1976929]: BUILD PASSED |
| ################################################################## | ||
| # RAPIDS Memory Manager | ||
| ################################################################## | ||
| include_directories(SYSTEM ${PROJECT_SOURCE_DIR}/third_party/rmm/include) |
There was a problem hiding this comment.
Can you check if that compiler for QNX, aarch64 and SBSA?
There was a problem hiding this comment.
QNX passed. I see no reason why SBSA would not, but I can try for CUDA 11 sake.
|
CI MESSAGE: [1977341]: BUILD STARTED |
dali/core/mm/mm_test_utils.h
Outdated
| ret = ua(bytes + sizeof(sentinel_t), alignment); | ||
| detail::write_sentinel<sentinel_t>(ret, bytes, std::forward<Extra>(extra)...); | ||
| } else { | ||
| ret = upstream_->allocate(extra..., bytes, alignment); | ||
| ret = upstream_->allocate(bytes, alignment, std::forward<Extra>(extra)...); |
There was a problem hiding this comment.
Why use ua in one place and upstream_ directly in the second?
There was a problem hiding this comment.
It's a bug. It should be ua.
…urce compiles. Signed-off-by: Michał Zientkiewicz <[email protected]>
|
CI MESSAGE: [1977856]: BUILD STARTED |
|
CI MESSAGE: [1977935]: BUILD STARTED |
Signed-off-by: Michał Zientkiewicz <[email protected]>
|
CI MESSAGE: [1977986]: BUILD STARTED |
|
CI MESSAGE: [1977986]: BUILD FAILED |
Signed-off-by: Michał Zientkiewicz <[email protected]>
|
CI MESSAGE: [1978196]: BUILD STARTED |
|
CI MESSAGE: [1978196]: BUILD FAILED |
|
CI MESSAGE: [1978369]: BUILD STARTED |
|
CI MESSAGE: [1977935]: BUILD PASSED |
|
CI MESSAGE: [1978369]: BUILD PASSED |
Why we need this PR?
Pick one, remove the rest
What happened in this PR?
Fill relevant points, put NA otherwise. Replace anything inside []
JIRA TASK: [DALI-1782] [DALI-1783]