Move tfrecord reader to readers module #2722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Signed-off-by: Krzysztof Lecki <[email protected]>
klecki
force-pushed
the
readers-tfrecord
branch
from
64adb35
to
110ace2
Compare
Signed-off-by: Krzysztof Lecki <[email protected]>
Signed-off-by: Krzysztof Lecki <[email protected]>
|
!build |
|
CI MESSAGE: [2108472]: BUILD STARTED |
JanuszL
reviewed
Feb 25, 2021
| // Schema for the actual TFRecordReader op exposed | ||
| // in Python. It is here for proper docstring generation | ||
| DALI_SCHEMA(TFRecordReader) | ||
| // Schema for the actual readers.tfrecord op expose in Python. |
There was a problem hiding this comment.
Suggested change
| // Schema for the actual readers.tfrecord op expose in Python. | |
| // Schema for the actual readers.tfrecord op exposed in Python. |
There was a problem hiding this comment.
As this is a comment, and the CI appears to be slow, I will fix it in a separate one.
jantonguirao
approved these changes
Feb 25, 2021
JanuszL
approved these changes
Feb 25, 2021
|
CI MESSAGE: [2108472]: BUILD PASSED |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why we need this PR?
For completeness with readers module
What happened in this PR?
What solution was applied:
TFRecordReader is special.
Added placeholders/alias schemas in the same fashion as other ops (to facilitate grepping with
readers__).Reworked the wrapper class to be internal only. Use it to create two proper wrapper classes inserted into appropriate modules and wrapped into corresponding fn api functions.
Affected modules and functionalities:
TFRecord Reader and related tests/notebooks
Key points relevant for the review:
If the doc is rendered and the op is accessible?
Validation and testing:
Documentation (including examples):
Some changes in docs.
JIRA TASK: [Use DALI-XXXX or NA]