Adjust notebooks to new decoder module #2743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Krzysztof Lecki <[email protected]>
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
jantonguirao
approved these changes
Mar 1, 2021
|
!build |
|
CI MESSAGE: [2119777]: BUILD STARTED |
JanuszL
reviewed
Mar 1, 2021
| @@ -47,11 +47,11 @@ | |||
| "source": [ | |||
| "### Explicitly Used Operators\n", | |||
| "\n", | |||
| " - The pipeline will use `readers.File` to provide the input images. We also need the `ImageDecoder` to decode the loaded images.\n", | |||
| " - The pipeline will use `readers.file` to provide the input images. We also need the `decoders.image` to decode the loaded images.\n", | |||
There was a problem hiding this comment.
I think you can remove "import nvidia.dali.ops as ops\n", as well.
JanuszL
approved these changes
Mar 1, 2021
|
CI MESSAGE: [2119777]: BUILD PASSED |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #2725.
Signed-off-by: Krzysztof Lecki [email protected]
Why we need this PR?
Refactor notebooks to use
decodersmodule.What happened in this PR?
What solution was applied:
Find and replace
Some names of operators referenced in text adjusted to lowercase/snake case.
Affected modules and functionalities:
Mostly Python notebooks
Key points relevant for the review:
Validation and testing:
CI
Documentation (including examples):
Yes, it's docs
JIRA TASK: [DALI-1882]