Propagate module and display name of the operator to backend #5344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klecki
changed the title
klecki
force-pushed
the
propagate-op-name
branch
from
716956c
to
6cccfdb
Compare
The "__" delimiter splitting of schema name into a module path and operator name is moved to backend. Python APIs are switched over to query the schema. ops.Compose is removed from registry of operators - it is mainly used to generate documentation and stubs, Compose is not really an operator but a special Python wrapper. It will be a standalone entity in the ops module and the documentation for it is now listed separately. Signed-off-by: Krzysztof Lecki <[email protected]>
Signed-off-by: Krzysztof Lecki <[email protected]>
Signed-off-by: Krzysztof Lecki <[email protected]>
Signed-off-by: Krzysztof Lecki <[email protected]>
Signed-off-by: Krzysztof Lecki <[email protected]>
Signed-off-by: Krzysztof Lecki <[email protected]>
Signed-off-by: Krzysztof Lecki <[email protected]>
Signed-off-by: Krzysztof Lecki <[email protected]>
Signed-off-by: Krzysztof Lecki <[email protected]>
klecki
force-pushed
the
propagate-op-name
branch
from
95a5440
to
7d6db21
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Signed-off-by: Krzysztof Lecki <[email protected]>
Signed-off-by: Krzysztof Lecki <[email protected]>
|
!build |
Signed-off-by: Krzysztof Lecki <[email protected]>
|
!build |
|
CI MESSAGE: [13311633]: BUILD STARTED |
|
CI MESSAGE: [13311633]: BUILD FAILED |
Signed-off-by: Krzysztof Lecki <[email protected]>
Signed-off-by: Krzysztof Lecki <[email protected]>
|
!build |
|
CI MESSAGE: [13315046]: BUILD STARTED |
klecki
added a commit
to klecki/DALI
that referenced
this pull request
Mar 6, 2024
Move module and op name partitioning to backend The "__" delimiter splitting of schema name into a module path and operator name is moved to backend. Python APIs are switched over to query the schema. ops.Compose is removed from registry of operators - it is mainly used to generate documentation and stubs, Compose is not really an operator but a special Python wrapper. It will be a standalone entity in the ops module and the documentation for it is now listed separately. Signed-off-by: Krzysztof Lecki <[email protected]> Propagate API and display name of the operator to backend Signed-off-by: Krzysztof Lecki <[email protected]> Some improvements Signed-off-by: Krzysztof Lecki <[email protected]> black Signed-off-by: Krzysztof Lecki <[email protected]> Flake Signed-off-by: Krzysztof Lecki <[email protected]> C++ lint Signed-off-by: Krzysztof Lecki <[email protected]> OpSpec::name() -> OpSpec::SchemaName() Signed-off-by: Krzysztof Lecki <[email protected]> Add naming utils to operators Signed-off-by: Krzysztof Lecki <[email protected]> Test stub Signed-off-by: Krzysztof Lecki <[email protected]> Finish the tests Signed-off-by: Krzysztof Lecki <[email protected]> Linting Signed-off-by: Krzysztof Lecki <[email protected]> Remove dead code Signed-off-by: Krzysztof Lecki <[email protected]> Add missing files Signed-off-by: Krzysztof Lecki <[email protected]> Cleanup Signed-off-by: Krzysztof Lecki <[email protected]>
|
CI MESSAGE: [13315046]: BUILD FAILED |
18 tasks
|
CI MESSAGE: [13315046]: BUILD PASSED |
banasraf
approved these changes
Mar 6, 2024
Signed-off-by: Krzysztof Lecki <[email protected]>
klecki
force-pushed
the
propagate-op-name
branch
from
5a0aad8
to
a6474ad
Compare
|
!build |
klecki
added a commit
to klecki/DALI
that referenced
this pull request
Mar 7, 2024
Move module and op name partitioning to backend The "__" delimiter splitting of schema name into a module path and operator name is moved to backend. Python APIs are switched over to query the schema. ops.Compose is removed from registry of operators - it is mainly used to generate documentation and stubs, Compose is not really an operator but a special Python wrapper. It will be a standalone entity in the ops module and the documentation for it is now listed separately. Signed-off-by: Krzysztof Lecki <[email protected]> Propagate API and display name of the operator to backend Signed-off-by: Krzysztof Lecki <[email protected]> Some improvements Signed-off-by: Krzysztof Lecki <[email protected]> black Signed-off-by: Krzysztof Lecki <[email protected]> Flake Signed-off-by: Krzysztof Lecki <[email protected]> C++ lint Signed-off-by: Krzysztof Lecki <[email protected]> OpSpec::name() -> OpSpec::SchemaName() Signed-off-by: Krzysztof Lecki <[email protected]> Add naming utils to operators Signed-off-by: Krzysztof Lecki <[email protected]> Test stub Signed-off-by: Krzysztof Lecki <[email protected]> Finish the tests Signed-off-by: Krzysztof Lecki <[email protected]> Linting Signed-off-by: Krzysztof Lecki <[email protected]> Remove dead code Signed-off-by: Krzysztof Lecki <[email protected]> Add missing files Signed-off-by: Krzysztof Lecki <[email protected]> Cleanup Signed-off-by: Krzysztof Lecki <[email protected]> Rework the _api into _module Signed-off-by: Krzysztof Lecki <[email protected]>
|
CI MESSAGE: [13344178]: BUILD STARTED |
klecki
changed the title
|
CI MESSAGE: [13344178]: BUILD PASSED |
Signed-off-by: Krzysztof Lecki <[email protected]>
mzient
approved these changes
Mar 7, 2024
|
!build |
|
CI MESSAGE: [13347837]: BUILD STARTED |
|
CI MESSAGE: [13347837]: BUILD PASSED |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Category: New feature, Refactoring
Description:
Move module and op name partitioning to backend.
The "__" delimiter splitting of schema name into a module path and operator name is moved to backend.
Python APIs are switched over to query the schema.
ops.Compose is removed from registry of operators - it is mainly used to generate documentation and stubs, Compose is not really an operator but a special Python wrapper. It will be a standalone entity in the ops module and the documentation for it is now listed separately.
Add new
_moduleand_display_namearguments that are updated by thefnandopsAPI bindings.OpSpec name() is adjusted to SchemaName() to differentiate that from the name/display name
of the operator and avoid the confusion.
New module that formats module path and operator display name is added in the backend.
Tests are added on Python level, to see if the bindings correctly propagate the snake_case
and CamelCase names (with the proper API specified).
The tests is based on the origin stack trace tests, both are generalized into simple common utility.
In a followup those utilities will be used to report better error messages.
Additional information:
Affected modules and functionalities:
API bindings generation - schema processing,
OpSpec and OpSchema APIs are adjusted and extended
New module for processing names in backend.
ops.Compose.
Key points relevant for the review:
Tests:
Checklist
Documentation
DALI team only
Requirements
REQ IDs: N/A
JIRA TASK: N/A