Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make protobuf a build time dependency for DALI python bindings in conda #5643

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

JanuszL
Copy link
Contributor

@JanuszL JanuszL commented Sep 20, 2024

  • makes protobuf a build time dependency for DALI python bindings in conda
    so it installs libprotobuf during the build time

Category:

Other (e.g. Documentation, Tests, Configuration)

Description:

  • makes protobuf a build time dependency for DALI python bindings in conda
    so it installs libprotobuf during the build time

Additional information:

Affected modules and functionalities:

  • dali_python_bindings recipe

Key points relevant for the review:

  • NA

Tests:

  • Existing tests apply
    • conda build process
  • New tests added
    • Python tests
    • GTests
    • Benchmark
    • Other
  • N/A

Checklist

Documentation

  • Existing documentation applies
  • Documentation updated
    • Docstring
    • Doxygen
    • RST
    • Jupyter
    • Other
  • N/A

DALI team only

Requirements

  • Implements new requirements
  • Affects existing requirements
  • N/A

REQ IDs: N/A

JIRA TASK: N/A

- makes protobuf a build time dependency for DALI python bindings in conda
  so it installs libprotobuf during the build time

Signed-off-by: Janusz Lisiecki <[email protected]>
@dali-automaton
Copy link
Collaborator

CI MESSAGE: [18586081]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [18586081]: BUILD FAILED

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants