Deb packaging #1113
Merged
Deb packaging #1113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flx42
reviewed
Sep 23, 2016
| UPSTREAM_VERSION=$(echo $SOURCE_VERSION | sed '0,/-/{s/-/~/}' | sed 's/-/\./g') | ||
| echo UPSTREAM_VERSION: $UPSTREAM_VERSION | ||
|
|
||
| GIT_REV=$(git stash create) |
There was a problem hiding this comment.
Maybe you should just abort if the environment is dirty.
flx42
reviewed
Sep 24, 2016
| dh-make \ | ||
| devscripts \ | ||
| equivs \ | ||
| lintian |
There was a problem hiding this comment.
It's recommend to clean the apt cache afterwards: https://docs.docker.com/engine/userguide/eng-image/dockerfile_best-practices/#/apt-get
There was a problem hiding this comment.
Ugh. It makes my build time slower. Ok.
| ARG DEBIAN_VERSION | ||
|
|
||
| WORKDIR /build | ||
| COPY tarball/* . |
There was a problem hiding this comment.
I don't think you need the /* here
| RUN debuild --no-lintian -i -uc -us -S -sa | ||
| RUN lintian ../*.changes | ||
| RUN mkdir -p /dist | ||
| RUN cp ../* /dist/ || true |
There was a problem hiding this comment.
No need to create so many layers, you should have fewer RUN commands.
There was a problem hiding this comment.
I don't think this really matters if I'm not actually distributing the docker image. But ok.
| --build-arg DEBIAN_VERSION=$DEBIAN_VERSION \ | ||
| . | ||
|
|
||
| set +e |
There was a problem hiding this comment.
Yeah this is dumb. Changing ...
lukeyeager
force-pushed
the
deb-packaging
branch
2 times, most recently
from
473dea1
to
4e60a25
Compare
lukeyeager
force-pushed
the
deb-packaging
branch
from
4e60a25
to
a81c07d
Compare
This was referenced Sep 28, 2016
SlipknotTN
pushed a commit
to cynnyx/DIGITS
that referenced
this pull request
Mar 30, 2017
Deb packaging
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Borrowed many things from nvidia-docker (thanks @3XX0!).