Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issue#1: pretrained model selection bug #16

Merged
merged 1 commit into from
Mar 23, 2015

Conversation

Sravan2j
Copy link
Contributor

  1. Removed the select field for previous networks snapshots from forms.py, due to wtforms validation issues. Then included code in views.py and new.html, to display the select fields for previous networks snapshots in html and for validating these fields. These changes fix the pretrained model selection bug. Also these changes ensure the display of error message, incase user selects the job that doesn't exists (this scenario happens when a user selects the job and at the same if another user deletes this job)
  2. fix to the following issue: when validation fails, the selected radio buttons in "previous networks" tab remains selected but the select input field and customize button beside the selected previous network is in hidden status, which is wrong. same issue exists in standard networks tab. Modified new.html to ensure that select field and customize button beside selected radio button will be visible even when validation fails.
  3. Modified the test case related to pretrained model selection.
  4. Included the changes to display the selected "pretrained model" details in show.html file

@lukeyeager
Copy link
Member

Thanks for the great work, @Sravan2j! Everything works great, I just added a few nitpicky comments.

@lukeyeager
Copy link
Member

Looks great, thanks for the fixes! Just squash all that into one commit and I'll merge it in.

1) Removed the select field for previous networks snapshots from forms.py, due to wtforms validation issues. Then included code in views.py and new.html, to display the select fields for previous networks snapshots in html and for validating these fields. These changes fix the pretrained model selection bug. Also these changes ensure the display of error message, incase user selects the job that doesn't exists (this scenario happens when a user selects the job and at the same if another user deletes this job)
2) fix to the following issue: when validation fails, the selected radio buttons in "previous networks" tab remains selected but the select input field and customize button beside the selected previous network is in hidden status, which is wrong. same issue exists in standard networks tab. Modified new.html to ensure that select field and customize button beside selected radio button will be visible even when validation fails.
3) Modified the test case related to pretrained model selection.
4) Included the changes to display the selected "pretrained model" details in show.html file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants