Add GPU performance tips for high performance LLMs with JAX/XLA #674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add GPU performance tips for high performance LLMs with JAX and XLA.
|
@abhinavgoel95, can you please review and provide feedback ? |
yhtang
reviewed
Apr 2, 2024
abhinavgoel95
previously approved these changes
Apr 2, 2024
nouiz
reviewed
Apr 3, 2024
nouiz
reviewed
Apr 3, 2024
|
@abhinavgoel95 or @nouiz, all conversations are resolved. Can one of you please approve, squash commits, and merge ? |
instinct79
changed the title
Remove default NCCL BUFF SIZE vars, add NCCL_NVLS_ENABLE
nouiz
reviewed
Apr 4, 2024
nouiz
reviewed
Apr 4, 2024
nouiz
approved these changes
Apr 4, 2024
|
@abhinavgoel95 anything else or I can merge now? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Documenting all JAX and XLA flags that we use for high performance LLMs with JAX/XLA.
Will update this periodically, and also link to
Per Yu-Hang's suggestion, will update https://github.com/NVIDIA/JAX-Toolbox/blob/main/README.md#environment-variables to this page as well, once the PR is merged.