Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add rosetta-maxtext #738

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

feat: Add rosetta-maxtext #738

wants to merge 11 commits into from

Conversation

ko3n1g
Copy link
Contributor

@ko3n1g ko3n1g commented Apr 18, 2024 •
edited
Loading

This PR adds a maxtext rosetta build. To be consistent with other rosetta builds, I renamed maxtext to upstream-maxtext.

🚨 It contains a test commit which must be removed before merging. 🚨

@ko3n1g ko3n1g requested a review from terrykong April 19, 2024 12:42
@ko3n1g ko3n1g marked this pull request as ready for review April 19, 2024 12:42
terrykong
terrykong reviewed Apr 19, 2024
View reviewed changes
.github/container/manifest.yaml
tracking_ref: main
latest_verified_commit: 78daad198544def8274dbd656d122fbe6a0e1129
mode: git-clone
patches:
mirror/patch/test_rosetta_maxtext: file://patches/maxtext/mirror-patch-rosetta-maxtext.patch
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just leaving a reminder that this can be cleaned up if not needed

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could not see the patch file in the repo. Are we using it?

terrykong
terrykong reviewed Apr 19, 2024
View reviewed changes
.github/workflows/_sandbox.yaml Outdated
@@ -1,41 +1,150 @@
name: "~Sandbox"

name: Sandbox
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a reminder to revert before merging

terrykong
terrykong reviewed Apr 19, 2024
View reviewed changes
.gitignore
@@ -0,0 +1 @@
local/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a debug line? Does it need to be committed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can remove it. I found it convenient to have local testing directory which isn't checked into git.

terrykong
terrykong requested changes Apr 19, 2024
View reviewed changes
Copy link
Contributor

@terrykong terrykong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! I left a few comments

@ko3n1g ko3n1g force-pushed the ko3n1g/rosetta-maxtext branch 2 times, most recently from fce07fc to 8e452da Compare April 22, 2024 12:30
@ko3n1g ko3n1g marked this pull request as draft April 22, 2024 12:30
@ko3n1g ko3n1g force-pushed the ko3n1g/rosetta-maxtext branch 2 times, most recently from a132242 to 0669659 Compare April 22, 2024 12:53
@ko3n1g ko3n1g force-pushed the ko3n1g/rosetta-maxtext branch 2 times, most recently from 99db46d to 24ce939 Compare April 22, 2024 13:43
@terrykong
Copy link
Contributor

I noticed the front-page readme doesn't have all the badges/rows we expect for maxtext:
image
Is this expected?

@ko3n1g ko3n1g marked this pull request as ready for review April 23, 2024 05:50
@ko3n1g ko3n1g requested a review from terrykong April 26, 2024 13:24
@ko3n1g ko3n1g requested a review from kocchop May 2, 2024 21:36
kocchop
kocchop requested changes May 2, 2024
View reviewed changes
Copy link
Contributor

@kocchop kocchop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few comments, please take a look

rosetta/Dockerfile.maxtext
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we again building TE here? The base image should be jax-mealkit:jax, right? And then we apply patch and build the final

.github/workflows/_ci.yaml
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we did not run the tests for rosetta-maxtext yet, right? we should check the validity of the rosetta build

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kocchop kocchop kocchop requested changes

@terrykong terrykong Awaiting requested review from terrykong

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ko3n1g @terrykong @kocchop