New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add pre-commit style checks #14

Merged

ryantwolf merged 2 commits into main from ayushdg/ci/style-check

Mar 25, 2024

Collaborator

ayushdg commented Mar 21, 2024

Add pre-commit-config
Fix some circular imports in the codebase
Move pytest and other black/isort configs to pyproject.toml


          Updates for pre-commit CI tests, add black, isort and other pre commi…

b3ed243

…t configs

Signed-off-by: Ayush Dattagupta <[email protected]>

ayushdg marked this pull request as ready for review

March 21, 2024 22:58

ayushdg requested a review from ryantwolf

March 21, 2024 22:58

ryantwolf approved these changes

View reviewed changes

Collaborator

ryantwolf left a comment

Unit tests are passing, and I can't find anything wrong after skimming the files the unit tests don't cover.


          Fix circular imports

a6d7aac

Co-authored-by: Ryan Wolf <[email protected]>
Signed-off-by: Ayush Dattagupta <[email protected]>

[pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

Add copyright & update py_version to 310

Signed-off-by: Ayush Dattagupta <[email protected]>

ayushdg force-pushed the ayushdg/ci/style-check branch from 339aa60 to a6d7aac Compare

March 22, 2024 18:45

ryantwolf merged commit 1c73ade into main

3 checks passed

ryantwolf deleted the ayushdg/ci/style-check branch

March 25, 2024 19:46

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet