Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove lxml installation #140

Merged
merged 2 commits into from
Jul 8, 2024
Merged

Remove lxml installation #140

merged 2 commits into from
Jul 8, 2024

Conversation

ryantwolf
Copy link
Collaborator

@ryantwolf ryantwolf commented Jul 5, 2024

Description

The original issue with justext was fixed in the latest patch so the import error we saw earlier should be gone now.

Usage

N/A

Checklist

  • I am familiar with the Contributing Guide.
  • New or Existing tests cover these changes.
  • The documentation is up to date with these changes.

Signed-off-by: Ryan Wolf <[email protected]>
@ryantwolf ryantwolf requested a review from ayushdg July 5, 2024 21:35
@ayushdg
Copy link
Collaborator

ayushdg commented Jul 8, 2024

@ryantwolf Could you resolve conflicts when you get the chance? Should be good to go once it's resolved

@ryantwolf ryantwolf merged commit 0fe0367 into main Jul 8, 2024
3 checks passed
@ryantwolf ryantwolf deleted the rywolf/justext branch July 8, 2024 21:58
sarahyurick pushed a commit to sarahyurick/NeMo-Curator that referenced this pull request Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants