Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nemo-ux cudagraph #10527

Closed
wants to merge 11 commits into from
Closed

nemo-ux cudagraph #10527

wants to merge 11 commits into from

Conversation

akoumpa
Copy link
Member

@akoumpa akoumpa commented Sep 18, 2024

What does this PR do ?

Adds support for cudagraph in NeMo2.0.

Example config:

gpt_config = llm.GPTConfig(
num_layers=1,
hidden_size=128,
ffn_hidden_size=256,
num_attention_heads=1,
seq_length=seq_length,
init_method_std=0.023,
hidden_dropout=0.0,
attention_dropout=0.0,
layernorm_epsilon=1e-5,
make_vocab_size_divisible_by=128,
normalization='RMSNorm',
masked_softmax_fusion=False,
# Cudagraph options
enable_cuda_graph=True,
use_te_rng_tracker=True,
gradient_accumulation_fusion=False, # This should be false with cudagraphs
)

Collection: [Note which collection this PR will affect]

Changelog

  • Add specific line by line info of high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

GitHub Actions CI

The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.

The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

@github-actions github-actions bot added the NLP label Sep 18, 2024
@akoumpa akoumpa changed the title small fix nemo-ux cudagraph plugin Sep 18, 2024
@akoumpa akoumpa changed the title nemo-ux cudagraph plugin nemo-ux cudagraph Sep 18, 2024
@akoumpa akoumpa force-pushed the akoumparouli/nemo_ux_cudagraph_plugin branch 9 times, most recently from f05857c to 3f88d73 Compare September 19, 2024 06:07
@akoumpa akoumpa force-pushed the akoumparouli/nemo_ux_cudagraph_plugin branch 2 times, most recently from 9c81095 to c93e66a Compare September 23, 2024 16:48
@akoumpa akoumpa added Run CICD and removed Run CICD labels Sep 23, 2024
akoumpa and others added 11 commits October 3, 2024 20:21
Signed-off-by: Alexandros Koumparoulis <[email protected]>
Signed-off-by: Alexandros Koumparoulis <[email protected]>
Signed-off-by: Alexandros Koumparoulis <[email protected]>
Signed-off-by: Alexandros Koumparoulis <[email protected]>
Signed-off-by: Alexandros Koumparoulis <[email protected]>
Signed-off-by: Alexandros Koumparoulis <[email protected]>
Signed-off-by: Alexandros Koumparoulis <[email protected]>
Signed-off-by: Alexandros Koumparoulis <[email protected]>
Signed-off-by: Alexandros Koumparoulis <[email protected]>
@JimmyZhang12 JimmyZhang12 force-pushed the akoumparouli/nemo_ux_cudagraph_plugin branch from d8be51f to c69f614 Compare October 4, 2024 03:21
@github-actions github-actions bot removed the NLP label Oct 4, 2024
Copy link
Contributor

This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.

@github-actions github-actions bot added the stale label Oct 19, 2024
Copy link
Contributor

This PR was closed because it has been inactive for 7 days since being marked as stale.

@github-actions github-actions bot closed this Oct 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant