-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
distributed checkpoint average script #7721
Conversation
Signed-off-by: Yi Dong <[email protected]>
Signed-off-by: Yi Dong <[email protected]>
Signed-off-by: Yi Dong <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comments overall looks great
Signed-off-by: Yi Dong <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm, thanks !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good on the high level - I don't know the details of the distributed checkpointing, so can't really check the logic thoroughly
* dist checkpoint average script Signed-off-by: Yi Dong <[email protected]> * change name Signed-off-by: Yi Dong <[email protected]> * change log message Signed-off-by: Yi Dong <[email protected]> * address comments Signed-off-by: Yi Dong <[email protected]> --------- Signed-off-by: Yi Dong <[email protected]> Signed-off-by: maxime burchi <[email protected]>
* dist checkpoint average script Signed-off-by: Yi Dong <[email protected]> * change name Signed-off-by: Yi Dong <[email protected]> * change log message Signed-off-by: Yi Dong <[email protected]> * address comments Signed-off-by: Yi Dong <[email protected]> --------- Signed-off-by: Yi Dong <[email protected]> Signed-off-by: Piotr Żelasko <[email protected]>
* dist checkpoint average script Signed-off-by: Yi Dong <[email protected]> * change name Signed-off-by: Yi Dong <[email protected]> * change log message Signed-off-by: Yi Dong <[email protected]> * address comments Signed-off-by: Yi Dong <[email protected]> --------- Signed-off-by: Yi Dong <[email protected]>
What does this PR do ?
a script to average distributed checkpoint files.