Change the megatron config lr scheduler default and fix to change partitions script #8094
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shantanu Acharya <[email protected]>
titu1994
previously approved these changes
Dec 28, 2023
|
jenkins |
Signed-off-by: Shantanu Acharya <[email protected]>
bmwshop
approved these changes
Dec 29, 2023
pzelasko
pushed a commit
to pzelasko/NeMo
that referenced
this pull request
Jan 3, 2024
…titions script (NVIDIA#8094) * fix the config file issues Signed-off-by: Shantanu Acharya <[email protected]> * disable sequence parallel for mcore Signed-off-by: Shantanu Acharya <[email protected]> --------- Signed-off-by: Shantanu Acharya <[email protected]> Signed-off-by: Piotr Żelasko <[email protected]>
ssh-meister
pushed a commit
to ssh-meister/NeMo
that referenced
this pull request
Feb 15, 2024
…titions script (NVIDIA#8094) * fix the config file issues Signed-off-by: Shantanu Acharya <[email protected]> * disable sequence parallel for mcore Signed-off-by: Shantanu Acharya <[email protected]> --------- Signed-off-by: Shantanu Acharya <[email protected]> Signed-off-by: Sasha Meister <[email protected]>
rohitrango
pushed a commit
to rohitrango/NeMo
that referenced
this pull request
Jun 25, 2024
…titions script (NVIDIA#8094) * fix the config file issues Signed-off-by: Shantanu Acharya <[email protected]> * disable sequence parallel for mcore Signed-off-by: Shantanu Acharya <[email protected]> --------- Signed-off-by: Shantanu Acharya <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two fixes:
optim.sched.constant_steps=0sequence_parallel=truein config when converting the model to TP=1.