Make TDT inference not require duration params #8207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hainan Xu <[email protected]>
titu1994
reviewed
Jan 23, 2024
| @@ -91,6 +91,11 @@ def __init__(self, cfg: DictConfig, trainer: Trainer = None): | |||
| else: | |||
| self.spec_augmentation = None | |||
|
|
|||
| if loss_name == 'tdt': | |||
There was a problem hiding this comment.
This part should be closer to the loss definition above. Colocation of similar things
artbataev
reviewed
Jan 23, 2024
| @@ -208,15 +208,17 @@ def __init__(self, decoding_cfg, decoder, joint, blank_id: int): | |||
| self.compute_timestamps = self.cfg.get('compute_timestamps', None) | |||
| self.word_seperator = self.cfg.get('word_seperator', ' ') | |||
|
|
|||
| if self.durations is not None: # this means it's a TDT model. | |||
| if self.durations is not None and self.durations != []: # this means it's a TDT model. | |||
There was a problem hiding this comment.
I personally prefer checking for bool, which is more idiomatic and follows PEP8
For sequences (strings, lists, tuples), use the fact that empty sequences are false
https://peps.python.org/pep-0008/#programming-recommendations
But the current approach is also acceptable for me since it works.
|
@hainan-xv Thanks for the PR; I think it makes it more convenient to use decoding with TDT models. One minor comment about style. |
added 3 commits
January 24, 2024 08:43
Signed-off-by: Hainan Xu <[email protected]>
Signed-off-by: Hainan Xu <[email protected]>
|
jenkins |
titu1994
approved these changes
Jan 24, 2024
yaoyu-33
pushed a commit
that referenced
this pull request
Jan 31, 2024
* Make TDT inference not require duration params Signed-off-by: Hainan Xu <[email protected]> * addressed review comments Signed-off-by: Hainan Xu <[email protected]> * stylistic change Signed-off-by: Hainan Xu <[email protected]> --------- Signed-off-by: Hainan Xu <[email protected]> Co-authored-by: Hainan Xu <[email protected]>
stevehuang52
pushed a commit
that referenced
this pull request
Jan 31, 2024
* Make TDT inference not require duration params Signed-off-by: Hainan Xu <[email protected]> * addressed review comments Signed-off-by: Hainan Xu <[email protected]> * stylistic change Signed-off-by: Hainan Xu <[email protected]> --------- Signed-off-by: Hainan Xu <[email protected]> Co-authored-by: Hainan Xu <[email protected]> Signed-off-by: stevehuang52 <[email protected]>
ssh-meister
pushed a commit
to ssh-meister/NeMo
that referenced
this pull request
Feb 15, 2024
* Make TDT inference not require duration params Signed-off-by: Hainan Xu <[email protected]> * addressed review comments Signed-off-by: Hainan Xu <[email protected]> * stylistic change Signed-off-by: Hainan Xu <[email protected]> --------- Signed-off-by: Hainan Xu <[email protected]> Co-authored-by: Hainan Xu <[email protected]> Signed-off-by: Sasha Meister <[email protected]>
pablo-garay
pushed a commit
that referenced
this pull request
Mar 19, 2024
* Make TDT inference not require duration params Signed-off-by: Hainan Xu <[email protected]> * addressed review comments Signed-off-by: Hainan Xu <[email protected]> * stylistic change Signed-off-by: Hainan Xu <[email protected]> --------- Signed-off-by: Hainan Xu <[email protected]> Co-authored-by: Hainan Xu <[email protected]> Signed-off-by: Pablo Garay <[email protected]>
rohitrango
pushed a commit
to rohitrango/NeMo
that referenced
this pull request
Jun 25, 2024
* Make TDT inference not require duration params Signed-off-by: Hainan Xu <[email protected]> * addressed review comments Signed-off-by: Hainan Xu <[email protected]> * stylistic change Signed-off-by: Hainan Xu <[email protected]> --------- Signed-off-by: Hainan Xu <[email protected]> Co-authored-by: Hainan Xu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Making it so that TDT inference doesn't require --duration params to be passed.
Collection: [Note which collection this PR will affect]
ASR
Changelog
The model now infers the duration params from model's loss configs.
Usage
# Add a code snippet demonstrating how to use thisJenkins CI
To run Jenkins, a NeMo User with write access must comment
jenkinson the PR.Before your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information