Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added compile fixture #37

Draft
wants to merge 32 commits into
base: main
Choose a base branch
from
Draft

Added compile fixture #37

wants to merge 32 commits into from

Conversation

markkraay
Copy link
Collaborator

@markkraay markkraay commented Aug 6, 2024 •
edited
Loading

This MR adds a compile fixture to our integration test suite so that we can test ops both lazily and using the compiler API. Addresses #256.

@markkraay markkraay self-assigned this Aug 6, 2024
jhalakpatel
jhalakpatel reviewed Aug 6, 2024
View reviewed changes
tripy/tests/integration/conftest.py Outdated Show resolved Hide resolved
tripy/tests/integration/conftest.py Outdated Show resolved Hide resolved
@markkraay markkraay force-pushed the dev-mkraay-fix-256-fixture-for-compile branch from 219f70f to c1df1e3 Compare August 6, 2024 20:18
@markkraay markkraay added the tripy Pull request for the tripy project label Aug 7, 2024
@markkraay markkraay force-pushed the dev-mkraay-fix-256-fixture-for-compile branch from 1571c22 to 1a386ed Compare August 12, 2024 17:27
@markkraay markkraay mentioned this pull request Aug 12, 2024
Open
markkraay
markkraay commented Aug 13, 2024
View reviewed changes
Copy link
Collaborator Author

@markkraay markkraay left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved here

@markkraay
Copy link
Collaborator Author

@pranavm-nvidia I will continue including details abt. failing test cases + MLIR dumps as I continue to enable compile_fixture for more tests. Let me know if there's any additional information / formatting that would be helpful :)

@pranavm-nvidia
Copy link
Collaborator

@pranavm-nvidia I will continue including details abt. failing test cases + MLIR dumps as I continue to enable compile_fixture for more tests. Let me know if there's any additional information / formatting that would be helpful :)

Could you also include the name of the failing test?

@markkraay markkraay force-pushed the dev-mkraay-fix-256-fixture-for-compile branch from b3ac379 to f424b2b Compare August 14, 2024 17:17
yizhuoz004
yizhuoz004 reviewed Aug 16, 2024
View reviewed changes
tripy/tests/integration/conftest.py


@pytest.fixture(params=["compile", "eager"])
def compile_fixture(request):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#102 (comment)

compile_fixture should be able to specify which args are constants / parameters. For Q/DQ, scale should be Parameters.

@yizhuoz004
Copy link
Collaborator

I do not see a lot of value in testing so many low-level APIs in compile mode. What is the time impact on L0?

@markkraay markkraay mentioned this pull request Aug 16, 2024
Open
@markkraay markkraay force-pushed the dev-mkraay-fix-256-fixture-for-compile branch from f032baa to 114ddf7 Compare August 20, 2024 17:00
@markkraay
try to dynamically add markers for compile / eager
e6636d8
@markkraay
enable test_flip: all tests passing
eb13a3d
@markkraay
enable test_full: failing test_shape_tensor[compile]
9cf2bc6
@markkraay
remove ir dump from test_full
c35b45f
@markkraay
enable test_iota; failing test_iota_from_shape_tensor[compile]
8c5ad76
@markkraay
remove extra fixture
18bcefc
@markkraay
enable test_linear; all tests passing
f9f4cb3
@markkraay
enable test_matrix_multiplication; all tests passing
82edeaf
@markkraay
enable test_reshape; all tests passing
0e02f61
@markkraay
enable test_cast: failing test_cast[compile-*] & test_cast_from_bool[…
a768de7 
…compile-int64]
@markkraay
enable test_concatenate: all tests pass
623f54c
@markkraay
enable & reformat test_plugin: all test passing
c998d30
@markkraay
enable test_convolution; all tests pass
8ce3f62
@markkraay
enable test_quantize; filed issue #102
a1d1735
@markkraay
enable test_functional; failing many
7d7de04
@markkraay
enabled test_conv_transpose; all tests passing
e146aa1
@markkraay markkraay force-pushed the dev-mkraay-fix-256-fixture-for-compile branch from 114ddf7 to e146aa1 Compare August 29, 2024 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhalakpatel jhalakpatel jhalakpatel left review comments

@pranavm-nvidia pranavm-nvidia pranavm-nvidia left review comments

@yizhuoz004 yizhuoz004 yizhuoz004 left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@markkraay markkraay

Labels
tripy Pull request for the tripy project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@markkraay @pranavm-nvidia @yizhuoz004 @jhalakpatel