Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Timing for build #1048

Merged
merged 8 commits into from
Aug 13, 2024
Merged

Timing for build #1048

merged 8 commits into from
Aug 13, 2024

Conversation

phu0ngng
Copy link
Collaborator

Description

This PR adds timing for build_ext, bdist_wheel, and total build time.

Type of change

  • Documentation change (change only to the documentation, either a fix or a new content)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Infra/Build change
  • Code refractor

Checklist:

  • I have read and followed the contributing guidelines
  • The functionality is complete
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@phu0ngng
add timing for build
16f8a96 
Signed-off-by: Phuong Nguyen <[email protected]>
zlsh80826
zlsh80826 reviewed Jul 28, 2024
View reviewed changes
build_tools/build_ext.py Outdated Show resolved Hide resolved
@phu0ngng phu0ngng marked this pull request as ready for review August 8, 2024 15:10
@phu0ngng phu0ngng requested a review from timmoon10 August 8, 2024 15:10
@phu0ngng phu0ngng mentioned this pull request Aug 9, 2024
Merged
13 tasks
@phu0ngng phu0ngng requested a review from ksivaman August 9, 2024 14:59
timmoon10
timmoon10 reviewed Aug 9, 2024
View reviewed changes
Copy link
Collaborator

@timmoon10 timmoon10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It feels like build time logging is something that should be handled by Pip or the logger. That said, this is very useful information and this PR is simple.

setup.py Outdated Show resolved Hide resolved
timmoon10
timmoon10 approved these changes Aug 13, 2024
View reviewed changes
setup.py Outdated Show resolved Hide resolved
phu0ngng and others added 2 commits August 13, 2024 13:43
@phu0ngng phu0ngng merged commit 516dacc into NVIDIA:main Aug 13, 2024
13 of 14 checks passed
@phu0ngng phu0ngng deleted the build_timing branch August 13, 2024 20:49
mgoldfarb-nvidia pushed a commit to mgoldfarb-nvidia/TransformerEngine that referenced this pull request Aug 14, 2024
@phu0ngng @mgoldfarb-nvidia
Timing for build (NVIDIA#1048)
172dd51 
* add timing for build

* using perf_counter

---------

Signed-off-by: Phuong Nguyen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zlsh80826 zlsh80826 zlsh80826 left review comments

@timmoon10 timmoon10 timmoon10 approved these changes

@ksivaman ksivaman Awaiting requested review from ksivaman

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@phu0ngng @timmoon10 @zlsh80826