-
Notifications
You must be signed in to change notification settings - Fork 320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[C/PyTorch] Userbuffers and comm+GEMM overlap algorithms refactored and moved to TE/common #1067
base: main
Are you sure you want to change the base?
Conversation
7255ca5
to
7c0cc8d
Compare
transformer_engine/pytorch/csrc/extensions/comm_gemm_overlap.cpp
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall this looks pretty good. My suggestions are quibbles with the API.
transformer_engine/common/include/transformer_engine/comm_gemm_overlap.h
Outdated
Show resolved
Hide resolved
transformer_engine/common/include/transformer_engine/activation.h
Outdated
Show resolved
Hide resolved
2e55bb2
to
dd8cc21
Compare
b3fb503
to
51519eb
Compare
4847133
to
10feff5
Compare
Signed-off-by: Alp Dener <[email protected]>
for more information, see https://pre-commit.ci
Signed-off-by: Alp Dener <[email protected]>
for more information, see https://pre-commit.ci
Signed-off-by: Alp Dener <[email protected]>
Signed-off-by: Alp Dener <[email protected]>
for more information, see https://pre-commit.ci
Signed-off-by: Alp Dener <[email protected]>
…areable file handle send/recv Signed-off-by: Alp Dener <[email protected]>
…ters so PyTorch can factor externally allocated memory into its garbage collection threshold Signed-off-by: Alp Dener <[email protected]>
for more information, see https://pre-commit.ci
…mmOverlapHelper to simplify Python function signatures Signed-off-by: Alp Dener <[email protected]>
for more information, see https://pre-commit.ci
Signed-off-by: Alp Dener <[email protected]>
…tstrapping Signed-off-by: Alp Dener <[email protected]>
…ceGetProp call with cached sm_count() Signed-off-by: Alp Dener <[email protected]>
for more information, see https://pre-commit.ci
…ion type defines with aliases Signed-off-by: Alp Dener <[email protected]>
Signed-off-by: Alp Dener <[email protected]>
Signed-off-by: Alp Dener <[email protected]>
for more information, see https://pre-commit.ci
Signed-off-by: Alp Dener <[email protected]>
for more information, see https://pre-commit.ci
3846102
to
a5504f1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. We can merge once we are passing CI.
… UB kernels Signed-off-by: Alp Dener <[email protected]>
/te-ci |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Description
This PR moves Userbuffers and comm+GEMM overlap algorithms from TE/PyTorch to TE/common with refactored interfaces to remove the PyTorch dependency.
Type of change
Changes
transformer_engine/pytorch/csrc/userbuffers
moved totransformer_engine/common/comm_gemm_overlap/userbuffers
.transformer_engine/pytorch/csrc/comm_gemm_overlap.h
split intotransformer_engine/common/include/transformer_engine/comm_gemm_overlap.h
andtransformer_engine/common/comm_gemm_overlap/comm_gemm_overlap.cpp
and refactored to removetorch::Tensor
dependency.Checklist: