-
Notifications
You must be signed in to change notification settings - Fork 321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TE with threading build #1092
Merged
Merged
TE with threading build #1092
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
4c760c8
added threading build back
phu0ngng a90721d
add options for pytorch and paddle extensions
phu0ngng 81fea66
added messages
phu0ngng 979b39b
Merge branch 'main' into build_threads
phu0ngng 5f71ee7
Update transformer_engine/common/CMakeLists.txt
phu0ngng b7bc0c5
Merge branch 'main' into build_threads
phu0ngng 8bc6bd2
renaming
phu0ngng e5e44e5
renaming
phu0ngng e8cbc5f
Merge branch 'main' into build_threads
phu0ngng File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@phu0ngng could you document here the reason for switching from 4 to 1 as a default?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As @timmoon10 mentioned, users getting stuck in the build process (#976, #978, #1077).
Besides, the PyTorch Ext build with
--thread 4
broke on my desktop. I discussed with Tim and we think it is better to have 1 as default so that all users have fewer build issues.For "advanced" users, they are encouraged to play with
NVTE_BUILD_THREADS_PER_JOB
to best match their system.