Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TE/JAX] Enabling CudaGraph for custom calls with FFI #1228

Merged
merged 6 commits into from
Oct 17, 2024

Conversation

phu0ngng
Copy link
Collaborator

@phu0ngng phu0ngng commented Oct 7, 2024

Description

This PR added traits=1 to the register_custom_call_target(), to enable cudaGraph for the custom calls with FFI.
This was somehow missing in #946.

Type of change

  • Documentation change (change only to the documentation, either a fix or a new content)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Infra/Build change
  • Code refractor

Checklist:

  • I have read and followed the contributing guidelines
  • The functionality is complete
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Signed-off-by: Phuong Nguyen <[email protected]>
@phu0ngng phu0ngng added the jax label Oct 7, 2024
@phu0ngng phu0ngng requested a review from nouiz October 7, 2024 19:52
Signed-off-by: Phuong Nguyen <[email protected]>
Signed-off-by: Phuong Nguyen <[email protected]>
Signed-off-by: Phuong Nguyen <[email protected]>
@phu0ngng
Copy link
Collaborator Author

/te-ci jax

@phu0ngng
Copy link
Collaborator Author

phu0ngng commented Oct 16, 2024

It was verified that cudaGraph capture worked for the three custom calls with FFI. Thus the PR is ready.

FYI, one can check if cudaGraph work via nsys, as:

$ XLA_FLAGS=--xla_gpu_graph_min_graph_size=1 nsys profile --cuda-graph-trace=node -o custom-call-graph --force-overwrite=true pytest tests/jax/test_custom_call_compute.py::TestActivationLu::test_activation_lu[activation_type0-shape0]
$ nsys stats -r cuda_kern_exec_trace --force-export=true custom-call-graph.nsys-rep

Copy link
Collaborator

@nouiz nouiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@phu0ngng phu0ngng merged commit 12f30ea into NVIDIA:main Oct 17, 2024
14 checks passed
@phu0ngng phu0ngng deleted the jax_cuda_graph branch October 17, 2024 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants