-
Notifications
You must be signed in to change notification settings - Fork 320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PyTorch] Reorganize L1 tests #1255
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tim Moon <[email protected]>
LGTM Can we add some way to run L1 tests from github? |
pggPL
approved these changes
Oct 16, 2024
Signed-off-by: Tim Moon <[email protected]>
Signed-off-by: Tim Moon <[email protected]>
Signed-off-by: Tim Moon <[email protected]>
Pipeline 19429427 seems to work as expected. The test failures don't seem related to this PR. |
Signed-off-by: Tim Moon <[email protected]>
Pipeline 19461229 |
timmoon10
added a commit
to timmoon10/TransformerEngine
that referenced
this pull request
Oct 18, 2024
Forgot to remove in NVIDIA#1255. Signed-off-by: Tim Moon <[email protected]>
14 tasks
timmoon10
added a commit
that referenced
this pull request
Oct 18, 2024
Remove PyTorch L0 distributed test Forgot to remove in #1255. Signed-off-by: Tim Moon <[email protected]>
timmoon10
added a commit
that referenced
this pull request
Oct 18, 2024
* Reorganize PyTorch L1 tests Signed-off-by: Tim Moon <[email protected]> * Move ONNX tests to L1 Signed-off-by: Tim Moon <[email protected]> * Move FA version test to L3 Signed-off-by: Tim Moon <[email protected]> * Limit parallel build jobs in FA version test Signed-off-by: Tim Moon <[email protected]> --------- Signed-off-by: Tim Moon <[email protected]>
timmoon10
added a commit
that referenced
this pull request
Oct 18, 2024
Remove PyTorch L0 distributed test Forgot to remove in #1255. Signed-off-by: Tim Moon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Our testing scheme currently looks like:
I propose the following:
This PR consolidates the distributed PyTorch tests into L1 and moves the GPT convergence test to L3.
Note that we're not really following the standard testing nomenclature since most of our Python L0 tests should be classified as L1 or L2. This matches our workflow though, so I don't see a need to be pedantic.
Type of change
Changes
Checklist: