Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PyTorch] Fix autocast deprecation warnings #1277

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

[PyTorch] Fix autocast deprecation warnings #1277

wants to merge 5 commits into from

Conversation

yaox12
Copy link
Collaborator

@yaox12 yaox12 commented Oct 21, 2024 •
edited
Loading

Description

Fix autocast deprecation warnings.

Starting from PyTorch 2.4, use

torch.get_autocast_dtype("cuda")
torch.amp.autocast("cuda")

instead of device-specific APIs.

Closes #1167.

Type of change

  • Documentation change (change only to the documentation, either a fix or a new content)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Infra/Build change
  • Code refractor

Checklist:

  • I have read and followed the contributing guidelines
  • The functionality is complete
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@yaox12 yaox12 force-pushed the xiny/fix_autocast_warning branch 2 times, most recently from 1420ea6 to 0987833 Compare October 21, 2024 03:01
@yaox12
Copy link
Collaborator Author

yaox12 commented Oct 21, 2024

/te-ci pytorch

@yaox12 yaox12 changed the title [PyTorch] Fix autocast deprecation warning [PyTorch] Fix autocast deprecation warnings Oct 21, 2024
@yaox12
Copy link
Collaborator Author

yaox12 commented Oct 21, 2024

/te-ci pytorch

@yaox12
Copy link
Collaborator Author

yaox12 commented Oct 23, 2024

/te-ci pytorch

@yaox12 yaox12 requested a review from ksivaman October 24, 2024 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timmoon10 timmoon10 Awaiting requested review from timmoon10

@ksivaman ksivaman Awaiting requested review from ksivaman

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yaox12 @ksivaman