Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Paddle] Update type names for Paddle 3.0 #1286

Merged
merged 1 commit into from
Oct 24, 2024

Conversation

timmoon10
Copy link
Collaborator

Description

We have experienced compilation errors when building with Paddle 3.0 since they've changed some type names in their CUDA graph infrastructure (see PaddlePaddle/Paddle#62832).

Pinging @eee4017

Type of change

  • Documentation change (change only to the documentation, either a fix or a new content)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Infra/Build change
  • Code refractor

Changes

  • Update type names for Paddle 3.0

Checklist:

  • I have read and followed the contributing guidelines
  • The functionality is complete
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@timmoon10 timmoon10 added the bug Something isn't working label Oct 24, 2024
@timmoon10
Copy link
Collaborator Author

/te-ci paddle

Copy link
Collaborator

@cyanguwa cyanguwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@timmoon10 timmoon10 merged commit 7a5fd0c into NVIDIA:main Oct 24, 2024
14 of 15 checks passed
@timmoon10 timmoon10 deleted the debug-paddle-graph branch October 24, 2024 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants