Fix _LIBCUDACXX_UNREACHABLE for old MSVC
#1114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miscco
requested review from
wmaxey and
griwes
and removed request for
a team
miscco
added
nvbug
miscco
force-pushed
the
fix_msvc_unreachable
branch
3 times, most recently
from
2f2a776
to
8065a4a
Compare
wmaxey
approved these changes
Nov 16, 2023
gevtushenko
approved these changes
Nov 16, 2023
miscco
force-pushed
the
fix_msvc_unreachable
branch
from
8065a4a
to
40e63c4
Compare
MSVC2017 / 2019 have issues properly determining that `__assume(0)` is indeed meant to mean unreachable code and complains about missing return statement sometimes. We can work around this by wrapping it into a `__declspec(noreturn)` function 🤷 Addresses nvbug4359466
miscco
force-pushed
the
fix_msvc_unreachable
branch
from
40e63c4
to
f5dccff
Compare
|
Backport failed for Please cherry-pick the changes locally. git fetch origin branch/2.3.x
git worktree add -d .worktree/backport-1114-to-branch/2.3.x origin/branch/2.3.x
cd .worktree/backport-1114-to-branch/2.3.x
git checkout -b backport-1114-to-branch/2.3.x
ancref=$(git merge-base aeaa3d39d3e32d7bb8a2aa2899fd51166db2667a f5dccff6c5e08556cf28c8f98c7faa74b10abe54)
git cherry-pick -x $ancref..f5dccff6c5e08556cf28c8f98c7faa74b10abe54 |
copy-pr-bot bot
pushed a commit
that referenced
this pull request
Nov 23, 2023
MSVC2017 / 2019 have issues properly determining that `__assume(0)` is indeed meant to mean unreachable code and complains about missing return statement sometimes. We can work around this by wrapping it into a `__declspec(noreturn)` function 🤷 Addresses nvbug4359466
wmaxey
pushed a commit
that referenced
this pull request
Nov 29, 2023
MSVC2017 / 2019 have issues properly determining that `__assume(0)` is indeed meant to mean unreachable code and complains about missing return statement sometimes. We can work around this by wrapping it into a `__declspec(noreturn)` function 🤷 Addresses nvbug4359466
miscco
added
backport done
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSVC2017 / 2019 have issues properly determining that
__assume(0)is indeed meant to mean unreachable code and complains about missing return statement sometimes.We can work around this by wrapping it into a
__declspec(noreturn)function 🤷Addresses nvbug4359466