Ensure the targets that Thrust creates are global. #1182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using CCCL via `add_subdirectory` the CCCL::Thrust target isn't visible to consumers. This is due to the fact that it is non-global and therefore scoped to the CCCL source directory. All other `CCCL::` targets are global so this brings everything inline
7 tasks
miscco
approved these changes
Dec 6, 2023
gevtushenko
approved these changes
Dec 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When using CCCL via
add_subdirectorythe CCCL::Thrust target isn't visible to consumers. This is due to the fact that it is non-global and therefore scoped to the CCCL source directory.Extend
thrust_create_targetto have theGLOBALoption to allow CCCL to ensure theCCCL::Thrusttargetis visible to consumers.
Checklist