Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce thrust benchmarks noise #1203

Conversation

gevtushenko
Copy link
Collaborator

Description

closes #1202

This PR introduces caching allocator policy into thrust benchmarks. This significantly reduces noise and runtime for thrust benchmarks. Apart from that, excluding memory allocation reduces number of modes in the elapsed time distributions.

caching_allocator

This is important for our performance CI.

Checklist

  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

Copy link
Collaborator

@elstehle elstehle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍
Big fan of factoring out noise from memory allocations!

@gevtushenko gevtushenko merged commit 58a527e into NVIDIA:main Dec 12, 2023
517 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[FEA]: Reduce noise of thrust benchmarks
2 participants