Silence some static asserts in ptx helpers #1257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miscco
added
nvbug
elstehle
approved these changes
Jan 9, 2024
ahendriksen
approved these changes
Jan 11, 2024
libcudacxx/include/cuda/std/detail/libcxx/include/__cuda/ptx/ptx_helper_functions.h
Outdated
Show resolved
Hide resolved
miscco
force-pushed
the
fix_ptx_static_asserts
branch
from
ffff4a4
to
cc6f6af
Compare
We only use if constexpr in C++17 so those functions are instantiated but never used. Fixes nvbug4384352
miscco
force-pushed
the
fix_ptx_static_asserts
branch
from
cc6f6af
to
d0f3d7d
Compare
|
GitHub Actions is not permitted to create or approve pull requests. |
miscco
added a commit
to miscco/cccl
that referenced
this pull request
Jan 16, 2024
We only use if constexpr in C++17 so those functions are instantiated but never used. Fixes nvbug4384352
jrhemstad
added a commit
that referenced
this pull request
Jan 17, 2024
We only use if constexpr in C++17 so those functions are instantiated but never used. Fixes nvbug4384352 Co-authored-by: Jake Hemstad <[email protected]>
miscco
added
backport done
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We only use if constexpr in C++17 so those functions are instantiated but never used, which is fine but the static assert triggers
Fixes nvbug4384352
We might want to backport this to 2.3.1